Adrian Cole

Consider following OpenTelemetry's broken implementation of trace-context

1

The W3C trace-context format has 2 headers. The primary one is `tracestate` which holds a durable copy of what would be in B3 single format. This is used in case...

[INFO] --- maven-invoker-plugin:3.2.1:run (default) @ brave-instrumentation-grpc --- [INFO] Building: grpc12/pom.xml Error: [ERROR] WARNING: An illegal reflective access operation has occurred Error: [ERROR] WARNING: Illegal reflective access by io.netty.util.internal.PlatformDependent0$1 (file:/home/runner/work/brave/brave/instrumentation/grpc/target/local-repo/io/netty/netty-common/4.1.8.Final/netty-common-4.1.8.Final.jar) to...

vertx-web tests fail on latest travis slave

3

I lost a lot of time today due to vertx-web tests crashing regardless of JDK install when I updated the OS like below. I reverted it for now. This issue...

Add HttpRequest.host()

8

This change follows from https://github.com/openzipkin/zipkin/issues/2167 The http host/authority is not always located in headers, at least not at all times. For example, some clients have static configuration regarding the host...

deprecate "grpc-trace-bin"

6

gRPC's "grpc-trace-bin" was a special header made by the OpenCensus project and later removed, when OpenCensus was removed from gRPC. As google integrated this into Envoy, there could be people...

The order isn't guaranteed by the test runner. The test should be rewritten to enforce order via latches or otherwise. ``` MutableSpan requestConsumerSpan = consumerSpanHandler.takeRemoteSpan(CONSUMER); MutableSpan replyProducerSpan = consumerSpanHandler.takeRemoteSpan(PRODUCER); MutableSpan...

Light OSGi tests

1

sometimes we have OSGi related glitches, such as missing internal specifiers. I know pax exists, but it has tended to be a bit slow part of the process. I noticed...

Makes default propagation for non-request spans B3 single

1

As described in the referenced issue. In-process messaging sometimes uses propagation, and the default of B3 multi makes the overhead quite bad. We should switch non-remote injection to B3 single...

build always downloads grpc dep..

4

I notice this in gRPC, but maybe somewhere else it occurs: ``` [INFO] -----------------------< io.zipkin.brave:brave >------------------------ [INFO] Building Brave 5.12.1-SNAPSHOT [2/40] [INFO] --------------------------------[ jar ]--------------------------------- Downloading from jfrog-snapshots: http://oss.jfrog.org/oss-snapshot-local/io/grpc/grpc-api/maven-metadata.xml Downloading...

[INFO] Running brave.spring.webmvc.ITSpanCustomizingHandlerInterceptor 11:58:24,790 WARN [qtp2057313197-409] servlet.DispatcherServlet (DispatcherServlet.java:1116) - No mapping found for HTTP request with URI [/foo/bark] in DispatcherServlet with name 'org.springframework.web.servlet.DispatcherServlet-4f5df8c7' [ERROR] Tests run: 33, Failures: 1, Errors:...