Adrian Cole

Results 360 issues of Adrian Cole

As discussed on https://github.com/openzipkin/b3-propagation/issues/21 and first implemented here: https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/propagation/B3SingleFormat.java https://github.com/openzipkin/brave/blob/master/brave/src/test/java/brave/propagation/B3SingleFormatTest.java Let's support at least reading "b3" header from a single string, most commonly traceid-spanid-1 It would also be nice to...

Conceding this is an uncommon use case, http2 has a 24bit unsigned length field. It feel cleaner if okhttp could ask okio to read/writeMedium. https://tools.ietf.org/html/draft-ietf-httpbis-http2-14#section-4.1

enhancement

We currently support logging of only IPv4 addresses. Starting with Zipkin 1.4, endpoints can omit IPv4 (by setting Endpoint.ipv4 to 0), and optionally log Endpoint.ipv6 as the raw 16byte address....

good first issue

The current tracing system is special-cased for client and server spans. There are non-rpc spans, such as expensive local code or messaging activity that are not currently representable in finagle....

help wanted

Let's support at least reading "b3" header from a single string, most commonly traceid-spanid-1 It would also be nice to support optionally writing this, especially in message providers or others...

good first issue
help wanted

One of the last frameworks to require the scribe transport is Finagle. On the server-side scribe not only is an archived architecture, but pins to abandoned libraries. It would help...

In Progress

When Finagle receives a 128-bit trace identifier, it should be able to propagate it without reducing its size to 64-bits. ### Expected behavior TraceId should have an extra field to...

help wanted

22 May 2020 will be 2 years of compatibility brought by minor updates of Brave 5. It is nearing time for another major release. Doing so will reduce burden both...

enhancement

This is inspired by Spring Cloud Sleuth, but uses the messaging spans from the v2 model. There's a certain amount of work left, just raising early.

At LINE, Xu JunJian noted that it may be tricky to propagate async contexts through co-routines. We should investigate this. https://kotlinlang.org/docs/reference/coroutines-overview.html

enhancement
help-wanted