Adrian Cole

Resurrect "default tags" feature

7

The old Collector component in brave had the ability to set default tags. The use cases for this weren't foreground, and we deprecated it a while back with no-one noticing...

Java Invocation correlation: `Span.invocation(...)`

10

## Current state It is quite normal to have access to Java invocation metadata, such as the method invoked and Java parameters. This is easily the case in AOP, such...

Zipkin's data model suggests that span names and service names are in downcase per https://zipkin.io/zipkin-api/#/default/post_spans This allows keyword based search and aggregations as opposed to case format agnostic ones, allowing...

investigate if we need to improve asynchronous handling of servlet

8

I was pinged on https://github.com/elastic/apm-agent-java/pull/385 by @felixbarny maybe we have something to adjust. cc also @nicmunroe my other servlet friend ;)

We should have tests to show how behavior is when folks do things like error handlers ```xml 403 /403.html /error.html java.lang.Throwable /BombServlet ```

Add advice for "resource layer" instrumentation, that it could be not called

2

@jkschneider warned > Careful about instrumenting WebMVC requests with a HandlerInterceptor because they are never called when a servlet filter intervenes earlier (e.g. spring-security blocks access to a resource). I'm...

Well over a year ago, Brave 5.3 introduced the single "b3" format, needed for JMS messaging. Since Kafka preceded this, we didn't immediately change in order to give time to...

Don't make spans for comments or SET statements in SQL

7

In playing with sleuth, which layers on brave now, I noticed we create spans for a whole lot of junk. This happens to the first trace on a JDBC connection....

OpenTracing defined a format which uses byte buffers. The current way is inefficient. ``` enum BinaryCodec implements Injector, Extractor { INSTANCE; final Charset ascii = Charset.forName("US-ASCII"); @Override public TraceContextOrSamplingFlags extract(BinaryExtract...

Right now, to add tags to the current span involves injecting a SpanCustomizer object, possibly CurrentSpanCustomizer. Feedback from some workshops from @jeffbeck suggest this could be difficult to grok for...