Adrian Cole

Results 412 issues of Adrian Cole

#584 added JMS support, including message listeners. Not all libraries use `JMSConsumer.setMessageListener(listener)` or `MessageConsumer.setMessageListener(listener)`. Notably, spring supports other means to invoke. This means we'll need to provide hooks to wrap...

Right now, we have `ScopeDecorator` for doing things special when a span is placed in scope. However, we still have a wrapping concern for propagation.. notably propagation can control the...

@liushunqiu spent a lot of time only to discover a configuration issue we would have noticed if our ITHttpServer tests did a POST request. Let's add a basic POST test.

ITTracingServerInterceptor occasionally dies like so when run as an invoker test for grpc v1.2 ``` [INFO] Running brave.grpc.ITTracingServerInterceptor 11:11:50,539 WARN [main] grpc.ITTracingServerInterceptor (ITTracingServerInterceptor.java:293) [/] - delayed getting a span; retrying...

We currently have JDBC instrumentation via https://github.com/p6spy/p6spy. This has been helpful, but we have also received feedback it is harder to configure, so some don't use it. Given limited resources,...

enhancement

We discussed this in dev chat 3-6 Sep with @shakuzen @zeagord @ivantopo The scenario is this: Someone uses ExtraFieldPropagation, yet they hit a snag as they enter JMS which has...

enhancement

There's a lot of copy paste, especially between different but similar messaging libraries (spring-rabbit, spring-messaging, jms). We should investigate a MessagingTracing/Handler thing similar to HttpTracing/Handler to reduce the techdebt and...

*Note* this issue is uncommon and can be solved in configuration. However, it may suggest we should make certain application layer instrumentation have the option to not create client or...

Processor spans happen after consumer ones.. the current "clock sharing" is scoped to span objects. The problem is that a consumer span opens and closes before a processor one does....

It would be nice to make an unsafe variant of Span, which requires external synchronization and doesn't plan on out-of-band updates. This will make it more efficient to implement layers...