Wenchen Fan comments

Results 245 comments of


                                            Wenchen Fan

[SPARK-52462] [SQL] Enforce type coercion before children output deduplication in Union

thanks, merging to master!

[SPARK-50029][SQL] Make `StaticInvoke` compatible with the method that return `Any`

thanks, merging to master!

[SPARK-52024][SQL] Support cancel ShuffleQueryStage when propagate empty relations

what if the shuffle stage is being reused by other places? I don't think we can cancel it without a ref counting to prove it's not used anywhere.

[SPARK-52024][SQL] Support cancel ShuffleQueryStage when propagate empty relations

I think it's more complicated than what you implemented now: what if the reuse stage is completed before we want to cancel the original stage? What if the reuse stage...

[SPARK-49506][SQL] Optimize ArrayBinarySearch for foldable array

thanks, merging to master!

[SPARK-54621][SQL] Merge Into Update Set * preserve nested fields if …coerceNestedTypes is enabled

Does this change anything when MERGE_INTO_NESTED_TYPE_COERCION_ENABLED is false?

[SQL][MINOR] Defensive code for number of Partitions in rCTEs

Is it possible to add a unit test by building physical plans directly? e.g. `RDDScanExec` can host a 0-partition RDD.

[SPARK-54609][SQL] Disable TIME type by default

can we add some test cases following the geo types blocking PRs?

[SPARK-54609][SQL] Disable TIME type by default

I removed all client side checks as it's not very meaningful. People can use the `TimeType` class directly and there is no point to only block SQL. People can use...

[SPARK-54405][SQL][Metric View] CREATE command and SELECT query resolution

thanks, merging to master!