Wenchen Fan

icon indicating an email [email protected]

icon company Databricks icon location Hangzhou, China

Results 245 comments of Wenchen Fan

[SPARK-52388][SQL] Handle named and positional parameters under `PlanWithUnresolvedIdentifier`

Hiding plans/expressions with a lambda function is evil. We should do the right thing even if it's not easy (need to fix commands one by one).

[SPARK-52388][SQL] Handle named and positional parameters under `PlanWithUnresolvedIdentifier`

I don't believe this is the right fix. We should fix every place in the parser to not hide plans/expressions within a lambda function.

[SQL][MINOR] Forbid duplicate SQLEXCEPTION and NOT FOUND handlers inside SQL Script

`SqlScriptingInterpreterSuite` fails

[SQL][MINOR] Forbid duplicate SQLEXCEPTION and NOT FOUND handlers inside SQL Script

Let's create a JIRA ticket. This is not a minor change. Otherwise LGTM

[SQL][MINOR] Forbid duplicate SQLEXCEPTION and NOT FOUND handlers inside SQL Script

thanks, merging to master/4.0!

[SPARK-52187][SQL] Introduce Join pushdown for DSv2

There is a linter failure ``` Checkstyle checks failed at following occurrences: Error: src/main/java/org/apache/spark/sql/connector/read/SupportsPushDownJoin.java:[50] (sizes) LineLength: Line is longer than 100 characters (found 108). Error: src/main/java/org/apache/spark/sql/connector/read/SupportsPushDownJoin.java:[51] (sizes) LineLength: Line is...

[SPARK-52187][SQL] Introduce Join pushdown for DSv2

thanks, merging to master!

[WIP][SPARK-49816][SQL][FOLLOW-UP] Fix conflicting CTE ids

@peter-toth Sorry for the late response. I've been struggling with this issue for a long time and can't make up my mind until recently that I find a design I'm...

[SPARK-51268][SQL] Make `TreeNode` lock-free

thanks, merging to master!

[SPARK-52462] [SQL] Enforce type coercion before children output deduplication in Union

@mihailoale-db can you say more about how your example query gets a different type coercion result with different rule order? Let's describe "not consistent" clearly here.