Wenchen Fan comments

Results 245 comments of


                                            Wenchen Fan

[SPARK-46037][SQL] Correctness fix for Shuffled Hash Join build left without codegen

cc @szehon-ho @dongjoon-hyun @viirya

[SPARK-46037][SQL] Correctness fix for Shuffled Hash Join build left without codegen

thanks for the review, merging to master/3.5!

[SPARK-49443][SQL][PYTHON] Implement to_variant_object expression and make schema_of_variant expressions print OBJECT for for Variant Objects

The link failure is unrelated, thanks, merging to master!

[SPARK-49119][SQL] Fix the inconsistency of syntax `show columns` between v1 and v2

In my opinion, we should not support `SHOW COLUMNS t FROM ...` in the first place. A fully qualified table name should do the work, there is no need for...

[SPARK-49119][SQL] Fix the inconsistency of syntax `show columns` between v1 and v2

You can identify a table with the qualified name. This is a common syntax in many other commands. `SHOW COLUMNS FROM t FROM schema` has no benefit but welcomes confusion.

[SPARK-49119][SQL] Fix the inconsistency of syntax `show columns` between v1 and v2

> ... which can somewhat decrease the confusion Yes, but I don't think we should make a breaking change only to reduce confusion for a legacy/unrecommanded feature.

[SPARK-49119][SQL] Fix the inconsistency of syntax `show columns` between v1 and v2

@panbingkun can you update `Does this PR introduce any user-facing change`? I think it does affect v2 tables.

[SPARK-49119][SQL] Fix the inconsistency of syntax `show columns` between v1 and v2

since it introduces a new error, shall we add a legacy config?

[SPARK-49119][SQL] Fix the inconsistency of syntax `show columns` between v1 and v2

@yaooqinn you are right! We don't need a config then :)

[SPARK-49383][SQL][PYTHON][CONNECT] Support Transpose DataFrame API

cc @HyukjinKwon for the question above.