Wenchen Fan

Results 245 comments of Wenchen Fan

@hvanhovell this rule needs to collect results and access `SparkSession`, which is not available in the catalyst module.

Hi all, sorry for the late review as I've been struggling with the user-facing API. I know we have a lot SHOW commands already but there are known issues: -...

BTW we already have a TVF to get all the SQL keywords ``` @ExpressionDescription( usage = """_FUNC_() - Get Spark SQL keywords""", examples = """ Examples: > SELECT * FROM...

I like specific functions for specific codecs, as it's easier to use. We can define an extra parameter for specifying the codec, but it's less readable and less friendly to...

Do we have a test case to demonstrate the issue? AFAIK Spark filters out 0-value accumulators at the executor side.

I'm not convinced by the added test, as it calls `SQLMetrics.stringValue` directly. In reality, the `values` parameter of this method comes from accumulator values from spark events. Are you sure...

I don't see any problem with the current `SQLMetric` framework. Let me give a summary here: 1. `SQLMetric` has an initial value. When executing the SQL operator on the worker...