spark icon indicating copy to clipboard operation
spark copied to clipboard

[SPARK-51268][SQL] Make `TreeNode` lock-free

Open zhengruifeng opened this issue 10 months ago • 1 comments

What changes were proposed in this pull request?

Make TreeNode lock-free, by replace lazy val with BestEffortLazyVal

Why are the changes needed?

In several deadlock issues, we observed that the lock of TreeNode._hashCode is the root cause.

Does this PR introduce any user-facing change?

no

How was this patch tested?

ci

Was this patch authored or co-authored using generative AI tooling?

no

zhengruifeng avatar Feb 20 '25 11:02 zhengruifeng

cc @JoshRosen and @cloud-fan

dongjoon-hyun avatar Feb 20 '25 16:02 dongjoon-hyun

thanks, merging to master!

cloud-fan avatar Jul 02 '25 04:07 cloud-fan

Thank you, @zhengruifeng , @cloud-fan and all.

dongjoon-hyun avatar Jul 02 '25 14:07 dongjoon-hyun