Clément Renaud
Clément Renaud
we are using gnosisscan as default verifier for gnosis now
We may want a syntax to differentiate contract using uniswap v2 from v3
@julien51 is that still needed now that we are planning to use depay?
one step closer with the subgraph deployment script
Hmm not sure why it got stuck. Let me check
/run-all-tests
> /run-all-tests so this works but the results aren't shown here :/ you have to dig into the "actions" tab to find it > https://github.com/unlock-protocol/unlock/actions/runs/3086054579 there is an open issue...
Just did it manually. Here are all functions that modifies state with their emitted events: | sig | event(s) emitted | | --- | --- | | `function addKeyGranter(address)` |...
So the list of functions that does NOT emit any events (but should) seems to be : #### Lock params setter metadata - [x] `function setBaseTokenURI(string)` - [x] `function updateLockName(string)`...
The PR is passing without integration tests so far, so just the docker images and scripts to run everything. I will add the actual tests to another PR as this...