Clément Renaud
Clément Renaud
ok unlock is configured properly and creating lock works from both dashboard and cli, but the graph doesnt seem to pick up new locks. It maybe indexing a wrong Unlock...
rhaa... wasted an hour to figure out that I actually needed to use some switch in the graph web dashboard to get the correct API key. At least I learnt...
yes absolutely. We need first #8055 which will also close #7659 - will add rollup and some various check.
yes possibly. We can have general rules written down, maybe even explicit the existing ones (like the mixins etc). Also would be good to enforce things with a stronger linter...
Renamed as « define sol contracts mint rules » so it becomes more actionable.
Here is a new plugin just out to support prettier for solidity https://github.com/prettier-solidity/prettier-plugin-solidity/releases/tag/v1.0.0?utm_source=substack&utm_medium=email
looking into it, solhint does quite a good job of catching inconstencies in contract writing style. We just need to enforce these better - that requires a rewriting/reordering of some...
https://github.com/unlock-protocol/unlock/pull/9418 has been merged so lets close this
Cool work @DevABDee ~ thanks for this ! I like the prefix on custom errors and may actually keep for other contracts
> Finally!!!!! :D Aug 3, 2022...