unlock icon indicating copy to clipboard operation
unlock copied to clipboard

feat(networks): add UniswapV2 oracle addresses for UDT

Open clemsos opened this issue 3 years ago • 3 comments

Description

This PR adds oracle addresses used for UDT prices to the network packages (when available)

  • [x] mainnet
  • [x] polygon
  • [x] rinkeby
  • [ ] xdai -> not deployed (see previous version UDT & Unlock addresses @julien51 )
  • [ ] optimism -> missing uniswap v2
  • [ ] goerli -> no UDT, oracle deployed at 0x5b45aC05B06A19E790A07e3613e807F1EeE5bA53 but not set in Unlock
  • [ ] mumbai -> no UDT
  • [ ] bsc -> no UDT
  • [ ] celo -> no UDT
  • [ ] avalanche -> no UDT
  • ~~[ ] localhost~~

Issues

Fixes #9518 Refs #

Checklist:

  • [ ] 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have updated the docs to reflect my changes if applicable
  • [ ] I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • [ ] I have performed a self-review of my own code
  • [ ] If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

clemsos avatar Sep 02 '22 08:09 clemsos

xdai -> not deployed

Oh I really think it was deployed on xDAI

julien51 avatar Sep 02 '22 12:09 julien51

Let's resume this once https://github.com/unlock-protocol/unlock/issues/9554 is solved!

julien51 avatar Sep 06 '22 17:09 julien51

We may want a syntax to differentiate contract using uniswap v2 from v3

clemsos avatar Sep 06 '22 20:09 clemsos

@julien51 is that still needed now that we are planning to use depay?

clemsos avatar Oct 14 '22 20:10 clemsos

@julien51 is that still needed now that we are planning to use depay?

Absolutely! Depay is used to swap and purchase. Here we need to take into account transactions for the GNP...

julien51 avatar Oct 17 '22 01:10 julien51