unlock icon indicating copy to clipboard operation
unlock copied to clipboard

feat(tests): add logic for integration tests

Open clemsos opened this issue 3 years ago • 2 comments

Description

This PR updates the way we deploy Unlock's infrastructure to make sure we can run integration tests through it

NB: the new eth-node was split into #9648 so should review and merge that one first, then rebase it

~~NB: This needs to be rebased once #9462 is merged~~

Issues

Fixes # Refs #

Checklist:

  • [ ] 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have updated the docs to reflect my changes if applicable
  • [ ] I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • [ ] I have performed a self-review of my own code
  • [ ] If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

clemsos avatar Sep 07 '22 15:09 clemsos

/rebase

julien51 avatar Sep 09 '22 19:09 julien51

The PR is passing without integration tests so far, so just the docker images and scripts to run everything. I will add the actual tests to another PR as this one is already big enough...

clemsos avatar Sep 20 '22 15:09 clemsos

@clemsos Do you think all tests need to run hardhat? I wonder if this isn't going to make our life harder for e2e front-end tests?

julien51 avatar Sep 28 '22 12:09 julien51

@clemsos Do you think all tests need to run hardhat? I wonder if this isn't going to make our life harder for e2e front-end tests?

the frontend e2e does not need to run hardhat but the subgraph does. We can have different testing logic in this repo with two different yarn tasks

also I think we should merge this PR once all the tests are green and work about more details in another one if possible

clemsos avatar Sep 28 '22 12:09 clemsos