Results 229 comments of Clément Renaud

should close this as it has been added there https://docs.uniswap.org/contracts/v3/reference/deployments

hello it seems the yarn `resolutions` approach mentioned @roninjin10 does not work as `ethers` is declared as a `peerDependencies` so there is no clear way to resolve that with yarn...

a fix is in the works at #10350

Most of these were done on v12 but we still have a few (updated the list here), so leaving this open for now

closing this as we now have all state modifying functions emitting events

This issue is quite broad, and we have #9270 #8055 that breaks it down

related PRs #10262 #10235 #9548

We need to make sure the signatures are on https://www.4byte.directory as its used on Tally to decide DAO calls - and it currently shows exceptions there https://www.tally.xyz/gov/unlock/proposal/67650238492744053870551188976528991701570154819711289520259087104693406921512?chart=list

one last missing thing here will be to verify past / older version of the contracts on Gnosis Scan. If not, I think we can close

ok transparent proxy used by unlock v11 has been verified (using solc 0.8.7 and oz contract 4.4.2 (see https://github.com/unlock-protocol/unlock/issues/9461#issuecomment-1323892771 )