Christoph Knittel

Results 126 comments of Christoph Knittel

I just ran into this issue, too, as I was using `Json.Decode.optional` to decode stuff encoded using `Json.Encode.nullable`. The encoder ```ml val nullable : 'a encoder -> 'a option ->...

(See #2507 and #2513 for previous issues with escaping "method".)

Also, ```reason let f = x => x##method; ``` gives ```js function f(x) { return x.method_; } ```

Same for React components, as they are using `bs.obj` internally: ```re module SomeComponent = { [@react.component] let make = (~method) => React.string(method); }; ; ``` gives ```js React.createElement(Teest$SomeComponent, { method_:...

Maybe `method` should just be forbidden and not escaped? Then the user is forced to use ```reason [@bs.obj] external request: (~_method: string) => request = ""; ``` which works fine.

I don't know if there is any "official" BuckleScript contract for that, but as a user of BuckleScript defining an external method in Reason syntax ```reason [@bs.obj] external request: (~a:...

For example, ```reason [@bs.obj] external request: (~type: string) => t = ""; ``` gives me a compile error: ``` Error: type is a reserved keyword, it cannot be used as...

Combining changes 1 and 2 make sense to me, and I am looking forward to them. 👍 However, I think a config switch would be better than tying this to...

Ok, thanks for the information. I was already suspecting that this might be due to the "do not flush warnings" feature. Still, the current workaround can lead to very unexpected...

It seems this also causes similar problems with Tailwind CSS (styles not being refreshed).