Christoph Knittel

Results 128 comments of Christoph Knittel

@cristianoc @bobzhang Did the `__unsafe_cast` thing in #5388 as requested. Had to commit the result of `./scripts/ninja.js build` to get tests passing.

Can you run `scripts/setVersion.js` to update the version in all places?

@bobzhang This would come in very handy for writing zero-cost bindings for the new ReasonReact.

For binding React components, the type of the result is the abstract type `React.element`. So this would definitely be very useful! 👍 Another use case would be "options" objects that...

`React.element` is defined here: https://github.com/reasonml/reason-react/blob/master/src/React.re

@rickyvetter This is the issue I mentioned yesterday. @jsiebern needs this for his material-ui bindings, too.

I think for now this is good idea to avoid inconsistencies, but for the longer term, we should investigate whether we can avoid checking in those snapshots with every change,...

Unfortunately my tests so far have shown that the build of the above files is non-deterministic, i.e., the output is different on every build. 😞 Therefore, I only made a...

Good point, I think we should actually define the `Rect` object type, as it is used in multiple places. After #766 / with ReScript 10, we can do this as...

It means that these are optional record fields, i.e., they can be omitted on record initialization and will also be omitted in the generated JS. ```rescript type rect = {...