Christoph Knittel
Christoph Knittel
> will set the .cmj file instead, note it will trigger some unneeded rebuild, but this will only affect code who has warnings, so it may not be a big...
In my desperation, I now tried to implement Bob's suggestion myself: > will set the .cmj file instead, note it will trigger some unneeded rebuild, but this will only affect...
The problem seems to be that there are two copies of the `Js` module, and you only modified one of them in #5539. The duplicate `Js` module was introduced here:...
As for 1., I was able to solve this by passing `--platform mingw` to ninja's configure script. MinGW is included out of the box in Github actions.
As for 2., the error occurs in this line ``` {j|File "$(s)", line $(linum), characters $(start)-$(finish): $(msg)|j} ``` @bobzhang @cristianoc Can it be that `Obj` is referenced indirectly here, e.g.,...
Actually in the cases where the build fails, `obj.ml` is not compiled before `printexc.ml`. Compare * Failed Windows build: https://github.com/rescript-lang/rescript-compiler/runs/6475670846?check_suite_focus=true#step:6:1 * Successful macOS build: https://github.com/rescript-lang/rescript-compiler/runs/6465960470?check_suite_focus=true So it seems that if...
> How about adding an explicit dependency at the place where Obj is use indirectly. `printexc.ml` is not the only one using template strings though, `arg.ml` is, too. Alternatively we...
@cristianoc I now just changed the template strings to string concatenation in `printexc.ml` because that was the easiest/quickest solution for me. Windows builds are now passing reliably. 🎉
@bobzhang That sounds good, but could we still get #5388 merged in the meantime so that I can finish the Windows CI?
@cristianoc Ok, plus changing ``` Ldot (Lident "Obj", "magic") ``` to ``` Ldot (Lident "Pervasives", "__unsafe_cast") ```` everywhere, right?