Charles Kerr
Charles Kerr
* Replace the `AddressRange` struct with a `std::pair`: The `AddressRange` searching / sorting code is complicated and hard-to-read. The pre-existing `tr_address` class already handles comparisons and has test coverage. The...
### What is the issue? Inspired by https://github.com/transmission/transmission/issues/4748. Maybe the `ENABLE_UTP` build option to compile without UTP isn't needed anymore. It was added IIRC a decade ago when one distro...
### What is the issue? Discussion from https://github.com/transmission/transmission/issues/4748 ``` trying to use system libutp from https://github.com/bittorrent/libutp gives another build failure: /home/users/builder/rpm/BUILD/transmission-4.0.0/libtransmission/peer-io.cc: In lambda function: /home/users/builder/rpm/BUILD/transmission-4.0.0/libtransmission/peer-io.cc:733:40: error: 'struct utp_callback_arguments' has no...
Fixes a long-standing bug (affects 4.0.0, 3.00, and apparently earlier) where Transmission initiates connection to a BitTorrent peer via uTP and just doesn't realize that the connection is not happening....
### What is the issue? I put in some test logging statements to track this down: ``` /tmp/transmission/libtransmission/torrent.cc:1525 s->percentDone '1.000000' hasTotal '727522671' sizeWhenDone '727522671' totalSize '727522671' /tmp/transmission/gtk/Torrent.cc:232 updating cache_.activity_percent_done. new...
Previous related: #3324, #4879, #4880. Possibly fixes #820. Thanks to @GaryElshaw for correctly noticing this smelled similar to 3324 and to @Coeur and @sweetppro for providing test data that helped...
### What is the issue? Instead of saying something like "Running time: 2 minutes", the details dialog says "2 minutes ago". ### Which application of Transmission? GTK+ app on Linux,...
A followup to #4826 which correctly diagnosed a problem (utp connections did not timeout correctly) but had a suboptimal solution. **Big** thanks to @reardonia for the review and analysis of...
Fixes https://github.com/transmission/transmission/issues/4891 but see the discussion in 4891's description. Notes: Fixed `4.0.0` rounding error in the progressbar's percentage display.