Charles Kerr

Results 81 issues of Charles Kerr

#### Description of Change Does what it says on the tin. `std::string_view` works everywhere, so let's use that and KISS. #### Checklist - [x] PR description included and stakeholders cc'd...

semver/patch
target/31-x-y
target/32-x-y
target/33-x-y
target/34-x-y

When I open `libtransmission/utils.h` in an editor, I see that the deleted methods in `tr_net_init_mgr` generate these warnings: ``` W tr_net_init_mgr(tr_net_init_mgr&&) = delete; /* W: deleted member function should be...

#### Description of Change Make `NativeWindow` fields private and/or const where possible #### Checklist - [x] PR description included and stakeholders cc'd - [ ] `npm test` passes - [x]...

new-pr 🌱
target/36-x-y
target/37-x-y

Squirrel FTBFS when building on macOS 11 with `-Wdeprecated-declarations,-Werror` due to a pair of [launchApplicationAtURL](https://developer.apple.com/documentation/appkit/nsworkspace/1534810-launchapplicationaturl) calls. We should migrate them to [openApplicationAtURL](https://developer.apple.com/documentation/appkit/nsworkspace/3172700-openapplicationaturl) instead. related: https://github.com/electron/electron/issues/43126, https://github.com/electron/electron/issues/43125

platform/macOS
component/auto-updater
upgrade-follow-up
stale-exempt

#### Description of Change Fix most of the warnings uncovered by [the first run](https://github.com/electron/electron/actions/runs/19665516853/job/56322988230?pr=49072) of @dsanders11's WIP clang-tidy GH Action. This PR fixes the trivial warnings but leaves `google-default-arguments` for...

semver/patch
no-backport

### Confirmation - [x] I am a [maintainer](https://github.com/orgs/electron/people) of the Electron project. (If not, please create a [different issue type](https://github.com/electron/electron/issues/new/).) ### Description Previous iteration was in outdated PR https://github.com/electron/electron/pull/42976.

## The problem I'm seeing deprecation warnings when including `small/map.hpp` after installing g++15. ### Steps to Reproduce Include `small/map.hpp` in small v0.2.2 when building an app with g++15. ### Output...

bug

Redesign `tr_quark` so that they don't all need to be declared in `quark.h`. This lets us move deprecated keys out of the global namespace and into `api-compat.cc`.

scope:core
type:refactor
notes:none

### What is the issue? 4.1.0-beta.4 saves data & config files like `stats.json` and `settings.json` in the new key naming scheme where all key names are formatted in snake_case. Having...

bug:regression