Christoph Fröhlich comments

Results 235 comments of


                                            Christoph Fröhlich

[JTC] When replacing trajectories in open-loop mode use time of the last command when setting point of trajectory before msg.

I'm asking myself if it is desirable at all to interpolate from measured state instead of the last command with closed-loop config. but that really depends on the algorithm generating...

tricycle_controller vs tricycle_steering_controller

What I understood so far: - **Tricycle_controller** has a single double-actuated wheel: steering and traction on the same wheel. This is basically a front-drive bicycle model, because it does not...

rqt_joint_trajectory_controller: Use urdf_parser

no one is working on that afaik. Thanks for picking this. I just had the idea when we were fixing a bug. Please check if it really makes sense/supports all...

ros2_control_node crashes abruptly with error "what(): Taking data from action server but nothing is ready

@saikishor @destogl @bmagyar I yet don't know why, but if the action server of JTC throws this `std::runtime_error`, can this kill the controller manager and then ros2_control_node? How is this...

ros2_control_node crashes abruptly with error "what(): Taking data from action server but nothing is ready

I've seen the `Taking data from action server but nothing is ready` exception already a couple of times in the CI, but this was some time ago. And we haven't...

Remove the '/' from tf_prefix when using the namespace of diff_drive_controller as tf_prefix

This sounds reasonable. Could you create a PR with your fix?

[ROS2_controller] Add community controllers in "Controllers for Mobile Robots" list on ROS2_control doc

Hi! Yes, this would be possible. But maybe @mateusmenezes95 wants to contribute to the ros2_controllers repository and add his controllers here? I see that there is already some documentation: I...

[ROS2_controller] Add community controllers in "Controllers for Mobile Robots" list on ROS2_control doc

Nice to hear. I see that there are already some tests there, there is not a lot missing to catch up with the controllers from our repo here (could be...

Use the urdf_ to set the robot_description in admittance controller

@SyllogismRXS could you please add this change to the kinematics_interface first, and then update this PR here?

Allow option to compute odometry from unpowered wheels

Hi! I was thinking a bit in this direction, to make the steering_library more configurable with setups as you describe. It stopped with https://github.com/ros-controls/ros2_controllers/pull/954 waiting for reviews (you want to...