ros2_controllers icon indicating copy to clipboard operation
ros2_controllers copied to clipboard

Use the urdf_ to set the robot_description in admittance controller

Open SyllogismRXS opened this issue 1 year ago • 3 comments

I'm running ROS2 Iron, building ros2_control and ros2_controllers from their master branches, but the admittance controller was complaining about the lack of the robot_description parameter in kinematics_interface_kdl (https://github.com/ros-controls/kinematics_interface/blob/master/kinematics_interface_kdl/src/kinematics_interface_kdl.cpp#L34).

The controller_manager now requires that the robot_description to not be a parameter, but come from a topic. I'm doing that. However, it seems that the admittance controller is still expecting robot_description as a parameter. In this PR, I set the robot_description parameter for the admittance controller using the urdf_ member variable. This feels a little hacky. Am I doing something wrong? Is anyone using the latest admittance controller successfully?

Thanks!

SyllogismRXS avatar Apr 05 '24 22:04 SyllogismRXS

@christophfroehlich I agree that passing the robot description in the initializer makes sense.

pac48 avatar Apr 07 '24 04:04 pac48

@SyllogismRXS could you please add this change to the kinematics_interface first, and then update this PR here?

christophfroehlich avatar Apr 07 '24 07:04 christophfroehlich

I modified the kinematics_interface package to accept the robot_description as an input argument with a fallback to using the node's parameters if the robot_description is empty: https://github.com/ros-controls/kinematics_interface/pull/66

SyllogismRXS avatar Apr 09 '24 18:04 SyllogismRXS

Closed in favor of #1247

destogl avatar Aug 14 '24 14:08 destogl