Carmi Grushko
Carmi Grushko
> It is intentional that we assume runtime_deps to keep deps minimal and rebuilds minimal. Huh, I guess this connects back to https://github.com/bazelbuild/rules_scala/issues/235, where `scala_library` would originally take the exact...
No; `java_library.exports` allows you to compile your code without `deps`-ing on the right things (it violates strict java deps, as defined in https://blog.bazel.build/2017/06/28/sjd-unused_deps.html). I want to require users to `deps`...
@ittaiz yep, I use "import" as a simplification. @johnynek `exports` circumvent strict java deps, while `runtime_deps` don't participate in compilation. On the other hand, `java_import` with `deps` doesn't circumvent strict...
I was copy-pasting a bunch of coords from https://mvnrepository.com/, where you can request the UI to print the coords in various ways. For projects with dozens of dependencies this might...
Looked at this again, indeed I was missing a `:jar` somewhere in there. My plan is to leverage `mvn dependency:tree` to print all dependencies in a `pom.xml` file and any...
Yeah, `http_archive` is deprecated: ``` Deprecated. load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") for a drop-in replacement. ``` I'm happy to review pull requests :)
@ychescale9 @eyalgu we started publishing artifacts to Maven Central: https://search.maven.org/artifact/com.facebook/ktfmt/0.12/jar @tasomaniac correct; `ktfmt` is a code formatter. It's analogous to google-java-format in the Java world.
https://github.com/diffplug/spotless/pull/569 is bringing `ktfmt` to Spotless. I see Store already uses Spotless, so it should be easy to try out `ktfmt`.
Funnily, it tripped our own tests. We have since converted to regular strings to make it more explicit. Do you suggest the formatter refuses to format such files? On Thu,...
Cool; I didn't see a test for trailing spaces, though? On Tue, Mar 31, 2020 at 2:43 PM Christian Stein wrote: > Closeable due to 4ddb914 > > methinks. >...