Carmi Grushko

Results 64 comments of Carmi Grushko

Thanks for the report. Expected behavior looks good to me, and improves the consistency of scoping function formatting. (changing to `val foo = ` puts the first lambda on the...

@steventrouble , iirc we had to roll this back; did you by chance look at this again?

I'm a bit torn on this, because ktfmt is not configurable on purpose. We _do_ support the "default" format (used internally at Facebook) and "google" format (used internally at Google...

I think we should revert this change as it causes data corruption for some users. A partial workaround exists, but (1) it doesn't do exactly the same thing, and (2)...

Curious - does GJF support doing this? If yes it should be easy to piggyback.

@cgruber , long time no see :) I'm not aware of anyone at Meta looking into that.

GJF does iirc, let's find out if we can reuse that code.

@zanesq, it should print "Error: 4:1: error: Imports not contiguous (perhaps a comment separates them?): // import some.commented.out.package" Does it not? How do you run ktfmt?

Agreed, and I like the "expected behavior". The "scoping function formatting" was a bit of a stopgap, because I didn't know how things should look like if the "first line"...