Carmi Grushko

Results 64 comments of Carmi Grushko

We're planning to integrate a new kdoc formatting engine: https://github.com/facebook/ktfmt/issues/339 IIRC we checked that it solves this issue specifically.

Since we share most of the plugin code with google-java-format, did you notice this behavior with their plugin as well? or is it irrelevant because Jetpack is Kotlin-only? Did they...

What version? I tried to repro on https://facebook.github.io/ktfmt/ with 0.43 and it produced: ``` val FOO: String = // language=json """ { "foo": "baz", "bar": null } """ .trimIndent() ```

Interesting. Should this be applied to top-level only? or all lambdas in kts files?

perhaps all top-level lambdas in kts files should be multiline?

As a workaround, does something like the following work? ``` find $DIR -name \*.kt | xargs tooling/scripts/format.sh ```

I'm thinking we should remove the semicolon from the formatted code, so this becomes ``` val testGetter: Boolean get() { return "OK" == "foo" } ``` (or whatever ktfmt outputs...

Sounds reasonable. Do you want to take a stab at it?

I think we went for one line annotations because of some idiosyncrasies in our code base. @strulovich did I remember correctly? (Meaning, doing one per line causes some of our...

This is how it looks in 0.31, I agree it's not perfect but it's an improvement: ``` val path = ShortestPath.unweightedShortestPathsFrom(start) { Stream.of(2.0, 3.0, 4.0, 5.0, 6.0, 7.0, 8.0, 9.0,...