Carmi Grushko

Results 64 comments of Carmi Grushko

I've been thinking of trying to migrate https://github.com/google/google-java-format, because (a) it doesn't use Bazel yet and (b) being Google, it's similar to the code we "trained" BFG on (e.g., not...

Yep, run BFG on, generate BUILD files and convince them they should switch.

In the meanwhile, you might be interested in https://github.com/cgrushko/text/blob/master/migrating-gjf-to-bazel.md which documents how I migrated google-java-format to Bazel using a tool we wrote later, Jadep. (Jadep is used internally at Google,...

GJF does this by expanding the formatted region to a minimal region that makes sense semantically. For example, formatting a line from a method would reformat the entire method. GJF...

What did you have in mind? Something like that? ``` [*.kt] indent_size = 4 # or 2 ``` (`ktfmt` only supports one flag: `--dropbox-style`.)

A single package group defined at the root that everyone else references, and includes the entire project. On Sep 27, 2017 21:52, "Petros Eskinder" wrote: > @cgrushko Style guide states...

IIUC it's broken because rt.jar no longer ships with Bazel. I'll take a closer look soon, but as a first measure, we can just disable building that failing target in...

I think the IDEA plugin is just old - I had trouble publishing the latest version due to some old APIs we're using.

Whoops, that's not a good experience. Let me see how hard it is to automatically upload stuff to GitHub's Releases (I think 0.21 is around the time I automated releases)

I refer to abstract classes in projects that BFG is invoked on, such as JavaRx (which I'm playing with to uncover bugs in BFG).