Martin Capitanio
Martin Capitanio
> these are two separate cases: > > * svgs with `viewbox="1 2 300 0"` (height=0) - nothing should be rendered - as I understand this is handled in godot...
The other option could be to remove everything from the SVG tag (this case works now, @mgrudzinska is almost there!) and render an equally sized transparent image (this would represent...
@fire You wrote the bindings, please correct me if I got it wrong. The debugger has troubles stepping in the code (godot changes thorvg's pointers to internal api or multithreading...
In web context it's used to currently hide or not render the image.
@mgrudzinska quick test for latest godot tip + pr1318 [godot_pr1318_diff.zip](https://github.com/godotengine/godot/files/10990870/godot_pr1318_diff.zip) Issues: svg without viewport/viewbox , \ (t8) and viewbox without viewport that contains 0s – get now marked as broken....
You were very hardworking :D _image_loader_svg.cpp_ hasn't been changed since 2022-12. You can clone the godot tip and run _git apply pr1318.diff_
Here are the docs what you need for any OS, may help: https://docs.godotengine.org/en/latest/contributing/development/compiling/index.html I can take a look at it over the weekend.
@mgrudzinska After https://github.com/godotengine/godot/pull/75034 the svg import is now error free for all images we get with a 0 size! The only small problem I can see is the case without...
@mgrudzinska > I hope that I've misunderstood - all of the images have a size equal 0? even if it shouldn;t be? Most images show a picture :+1: I didn't...
🤔 shouldn't a node without (connected) parent always have a **global** initial state of _zero_? With current patch: ``` room = Node3D.new() ### node state Room Local: Transform3D(1, 0, 0,...