Christoph Anton Mitterer

Obviously this could also be a bug in the command line tool and not the library, so I've reported it there as well: nu774/fdkaac#19.

Well it's a bit more than just the spike... just look at the image above, which include the original WAV. Everything what the WAV has less, is too much at...

Well it's of course clear that there are extra samples due to the block based encoding, but I would have expected that the encoded audio is just longer, but everything...

Same as before: now directly as pull request. And again, please thoroughly read what I've written and check it for any mistakes!

Oh and one more thing: Are those 4 KiB really hardcoded as such, or is actually the PAGE_SIZE? If the later I'd need to update this.

> @calestyo Could you review it? Will take a while...

Okay I did a "review" now,.. though admittedly it was more testing rather than reviewing (I'm really not that much of an expert with bash specific shell language features).. Some...

(didn't check with your two most recent commits, but AFAICS, these anyway just rename stuff)

With side effects above, I especially meant: - What if `_comp_finalize` is called (because of the trap) from any unrelated user function, that has e.g. `_comp_finalize__depth` overriden? - bash has...

> I take these comments as invalid ones. I hadn't said that there **were** injection holes,… I’ve asked whether there could be! ;-) > could you point it more specifically...