Bård Skaflestad

BuildFaceToCell Calling EntityRep::setValue() With Index of "-1"

4

I was debugging another issue when an `assert` triggered in [`EntityRep::setValue()`](https://github.com/OPM/opm-grid/blob/723e0d3591bcd2e4c9b6b4b2c9c5f5f3a6993e90/opm/grid/cpgrid/EntityRep.hpp#L120). The direct cause of this assertion failure was function [`cpgrid::buildFaceToCell()`](https://github.com/OPM/opm-grid/blob/723e0d3591bcd2e4c9b6b4b2c9c5f5f3a6993e90/opm/grid/cpgrid/processEclipseFormat.cpp#L785) calling [`setValue()`](https://github.com/OPM/opm-grid/blob/723e0d3591bcd2e4c9b6b4b2c9c5f5f3a6993e90/opm/grid/cpgrid/processEclipseFormat.cpp#L823) with ``` other_cell = -1 ``` There...

Stop Processing if COPYing From Undefined Source Array

2

This PR adds defined value checking to the source array from which we're copying in a `COPY` operation–either with the `COPY` or with the `COPYREG` keywords. We count the number...

Output CNV Histogram to INFOITER File

4

This PR tracks the number of cells and their associate fraction of the model's "eligible" pore volume (total pore volume in numerical aquifers subtracted from the model's total pore volume)...

Revise Mixture Density Method for No-Flow Producers

2

This PR switches the approach introduced in commit eeb1b7e36c9ae3c30ba5d262fa623dc0eea2e10b (PR #3169) to using a mobility weighted average of cell level densities for the connection level mixture densities in no-flow producing...

Implement 'RFIP' and 'SFIP' Mnemonics For RPTRST

5

The `FIP` mnemonic continues to be an alias for 'SFIP' in the current implementation, and the output layer will create the `SFIP*` arrays as copies of `FIP*` if passed only...

Enable New Saturation Function Consistency Checks

6

Currently opt-in by the new parameter `CheckSatfuncConsistency` (command line option `--check-satfunc-consistency`), this PR hooks up the `SatfuncConsistencyCheckManager` pass to the `FlowProblem`. I hope to make the parameter be "opt-out" at...

Add Top Level Container for Saturation Function Consistency Checks

2

This PR introduces a new top-level "manager" for all saturation function consistency checks. This component associates collections of saturation function curves with per-cell or per-region end-point definitions and provides an...

Add Protocol for Populating Saturation Function End Points per Cell

2

This PR introduces a set of callback functions, packaged in an abstract base class `SatfuncCheckPointInterface`, for querying and populating the saturation function end-points that get probed by the individual consistency...

Model 1 From SPE 10 Benchmark No Longer Produces Expected Output

2

I tested the [SPE10_MODEL1.DATA](https://github.com/OPM/opm-data/blob/eaa2261683a97027e057c2bc49612ad1c86390b3/spe10model1/SPE10_MODEL1.DATA) from the OPM-Data repository this morning and the model no longer produces the expected output from Flow (`mpirun -np 8 ${cse}`). The injector shuts down immediately...

Simulator Must Detect Incompatible Linear Solver Combinations

2

At the time of writing, the simulator will/may crash if the user tries to run a case using the new default settings from PR #5147, especially using the CPRW linear...