OPM
Implement 'RFIP' and 'SFIP' Mnemonics For RPTRST
The FIP mnemonic continues to be an alias for 'SFIP' in the current implementation, and the output layer will create the SFIP* arrays as copies of FIP* if passed only the FIP arrays.
To this end, make outputFipRestart_ into a structure that tracks which of the *FIP mnemonics have been requested, and insert the pertinent solution arrays into the data::Solution object when needed.
While here, also properly initialise the output module's bool flags and insert blank lines in the copyright header to make it more in line with the rest of the copyright statements in this repository.
I'm creating this PR in draft mode because it needs additional testing before it's ready for review and merging. I will keep the PR in a draft state until that time.
We've tested this on a field case and the results are encouraging. I'm marking this as "ready for review" now and I'm running a build check. I expect a couple of regression test failures due to slightly different handling of FIP now, but I'll address those when we know the outcome of the build check.
Upon review, the WATER2F regression failure is expected. The case has
-- Schedule reporting
RPTSCHED
FIP=2 WELLS=2 SUMMARY=1 WELSPECS
RESTART=2 / NEWTON=2 CPU=2
-- Restarts 1/2=rep, 3=freq, 4=year, 5=month, 6=ts
RPTRST
BASIC=2 FREQ=1 KRW KRG KRO SFIP RFIP DEN VISC ALLPROPS / FLOWS ROCKC
in its SCHEDULE section and due to the way we handle RPTSCHED, the FIP=2 request gets treated as if it was
RPTRST
FIP /
instead. This is arguably an error in our RPTSCHED handling, but we will not address that here. Nevertheless, this PR means we prioritise the explicit SFIP and RFIP requests in RPTRST over the FIP request from before and it is therefore expected that the result set will not have any FIPOIL, FIPGAS, or FIPWAT arrays in its restart file. We'll need to update the reference solutions to adapt to this new behaviour once the PR is approved and ready for merging.
PR approved, build check is green and the new reference solutions have been installed on the CI system. I'll merge into master.