opm-simulators icon indicating copy to clipboard operation
opm-simulators copied to clipboard

Add Top Level Container for Saturation Function Consistency Checks

Open bska opened this issue 1 year ago • 2 comments

This PR introduces a new top-level "manager" for all saturation function consistency checks. This component associates collections of saturation function curves with per-cell or per-region end-point definitions and provides an inteface to run all checks for all interior entities (i.e., active cells) in a DUNE grid view. We form one set of SatfuncConsistencyChecks objects for each SatfuncCheckPointInterface<> object, thereby enabling running the same set of consistency checks for both the unscaled, tabulated, per-region saturation functions and the per-cell scaled saturation functions. The latter is executed only if the run enables end-point scaling for the saturation functions.

As an aid to enabling the pertinent individual checks, we add a private factory function which considers the run's active phases and whether or not the run uses the alternative, three-point horizontal scaling method ("SCALECRS = YES").

bska avatar Sep 10 '24 13:09 bska

I'm creating this PR in draft mode because it depends on, and contains, the earlier PR #5589. I will keep the PR in a draft state until such time as it is ready for review.

bska avatar Sep 10 '24 13:09 bska

jenkins build this please

bska avatar Sep 10 '24 13:09 bska

The upstream PR #5589 was merged into the master branch. I'm marking this PR as "ready for review" and I'm running a build check.

bska avatar Oct 11 '24 11:10 bska

jenkins build this please

bska avatar Oct 11 '24 11:10 bska

jenkins build this please

bska avatar Oct 14 '24 15:10 bska

jenkins build this please

bska avatar Oct 15 '24 15:10 bska

jenkins build this please

bska avatar Oct 16 '24 07:10 bska

Thanks for explanations and revisions. Merging!

atgeirr avatar Oct 16 '24 10:10 atgeirr