OPM
Enable New Saturation Function Consistency Checks
Currently opt-in by the new parameter CheckSatfuncConsistency (command line option --check-satfunc-consistency), this PR hooks up the SatfuncConsistencyCheckManager<> pass to the FlowProblem. I hope to make the parameter be "opt-out" at some point, but for now the new pass breaks too many regression tests.
I'm creating this in draft mode for two reasons
- The PR depends on, and contains, the earlier PR #5592
- I'd like to refine the new parameter, ideally to not exist at all, but that will probably require adjustments to the underlying systems to avoid breaking the regression tests.
This functionality has been tested in Equinor and I'm looking forward to see this going into master.
The upstream PR was merged into the master branch. I've pushed an update here that adds a second new command line parameter, --num-satfunc-consistency-sample-points, in addition to --check-satfunc-consistency that was here when the PR was first created. The --num-satfunc-consistency-sample-points parameter allows the user to request more or fewer sample points than the default value of five and I've updated the PR description to reflect this fact.
I'm marking this PR as "ready for review" now.
I've pushed an update which adds a few more comments to explain the reasoning and I've moved the MPI barrier closer to where the simulation stops in the case of "critical" consistency failures.
