Brent Shaffer

Results 407 comments of Brent Shaffer

Adding onto this, it would also be great to separate out static methods in the Client classes, since the static methods are helper formatter methods, and the non-static ones are...

I believe this happens in `owlbot.py`, where we use the npm prettier plugin, defined as `plugin-php@^0.16`: https://github.com/googleapis/google-cloud-php/blob/0e9d8cd126c473fcd3f60e762ef155649be2ceab/DialogflowCx/owlbot.py#L51-L62 If that's the case then it seems like we're already pinned, and I'm...

Closing in favor of https://github.com/googleapis/gapic-generator-php/issues/711, as this is the best way to resolve the issue.

Hello @gaea44! unfortunately, as we still support PHP 7.4 (something that will be changing in the next couple months), we cannot support `psr/log:3` because the interface requires union types, and...

@diptanshumittal is this PR ready to merge?

Closing due to inactivity

@tscni thank you for reporting this issue! You are correct that the underlying auth library can throw a Guzzle exception. We can look at updating the PHPDoc to reflect this....

Closing in favor of 3 separate packages (https://github.com/googleapis/google-cloud-php/pull/7309)

We just had an error related to this happen again. See https://github.com/googleapis/google-auth-library-php/issues/504 and the resulting fix in https://github.com/googleapis/google-cloud-php/pull/6896