Brent Shaffer
Brent Shaffer
> Can you give an example of what you mean? An API removes a field `fieldA`. We keep the PHP methods `getFieldA` and `setFieldA`, because rather than throw a PHP...
@haberman I think the misunderstanding is that we want to keep the _previously generated_ protobuf file in favor of the new one. We don't want any protobuf message to be...
@stanislav-janu Ideally, we would fix this error by _not_ assign dynamic properties to classes in PHP. The error I'm getting is: ``` PHP Deprecated: Creation of dynamic property Google\Protobuf\Internal\MapFieldIter::$key_type is...
I see, it seems like these issues are actually in the subclasses, but the warning is thrown in the `Message` class, since it's the parent class. This is a different...
@stanislav-janu I looked into this a little more, and the expected property is [$schema_restriction_response](https://github.com/googleapis/google-cloud-php/blob/main/AnalyticsData/src/V1beta/ResponseMetaData.php#L32), so I'm not sure why the one you have is prefixed with an underscore. Is it...
@stanislav-janu that part of the file is binary, so I'm not sure that's what is causing it. Could you provide the code you used to duplicate the issue? I tried...
@Leprechaunz we should remain consistent with how PHP treats `unset`, and not reindex the array. Why not just use `unset` instead of `array_splice`?
@Leprechaunz thank you for the explanation, that makes sense! It's also probably why the original implementation was written like it is (only unsetting the last element). Since this is new...
The only issue I can think of is for libraries like `google-cloud-php`, we wouldn't want to _remove_ the `class_alias` code from proto files which currently have it. Not because we...