Warner Losh
Warner Losh
@asomers @markjdb @oshogbo Any final comments? Looks like there's a few unresolved comments still, but they look minor. @kfv Anything else?
@markjdb any final comments?
@kfv What's the status here? As far as I can tell, it's been requested that you use the capsicum_helper routines instead w/o a response for a long time.
So a few comments. The code looks OK to my eye. But I'd drop: - from(1): Remove braces from single-line conditional statements for consistency to meet style(9) compliance And there...
So I like this concept. However, I have some problems with the implementation. A kernel config option likely isn't the best way to do this. But it also brings up...
landed. Thanks! this one looks to be uncontested.
OK, I saw John's review but didn't read #1083 closely enough... I've backed this out in -current and will leave this closed. Pull requests aren't the place to hash out...
> Do you know what was the failure in armv7? Alignment requirement increased by cast. The feedback was that it would be better if this were opt in rather than...
Im pretty sure most of these are an incorrect application of this spelling. Specifically, returns nonzero is right, but non-zero number is also right because non modifies more than one...
I'm saying that the style I've seen is that non-zero is hyphenated only when it modifies a noun, but not when used as a noun or on it's own. That...