Warner Losh comments

Results 449 comments of


                                            Warner Losh

grep: fix output duplication when number of matches is greater than MAX_MATCHES

The conflicts that were detected were larger than I felt comfortable resolving. This needs to be rebased to proceed.

New license request: BSD-2-Clause-Copyright [SPDX-Online-Tools]

I think this needs to be a new license. It's another instance of at start of file varaints of the BSD license.

New license request: BSD-2-Clause-Copyright [SPDX-Online-Tools]

I still agree with @jlovejoy that this is a separate license, and like her suggestion of `bsd-2-clause-first-lines`. I'd be interested in the thinking behind the suggestion that the start of...

Make bpf interop consistent with if_loop

> I think this patch looks good. I wonder why we set a special `sa_family` to begin with - it looks like BPF can just set `bd_hdrcmplt` and avoid using...

Make bpf interop consistent with if_loop

(I ticked needs-review so I'll check back for Mark's answer later)

Update atomic.h, 64 bit compare exchange on ARM 32

The commit message is missing a why: What is the bug and why does this fix that bug?

mfiutil: Fix unsafe assumptions of snprintf(3) return value in function `mfi_autolearn_period`

looks like negative return value from snprintf isn't handled still...

mfiutil: Fix unsafe assumptions of snprintf(3) return value in function `mfi_autolearn_period`

Automated message from ghpr: Thank you for your submission. This PR has been merged to FreeBSD's branch. These changes will appear shortly on our GitHub mirror.

e6000sw: Add support for MV88E6190X switch variant

rylish's comments need to be addressed.

e6000sw: Add support for MV88E6190X switch variant

> hi! This has been landed in -HEAD now, thanks! Thanks!