Brian Sardo
Brian Sardo
Discussed again backlog. There is a possibility the targeting keyword might need to be moved from the execution plan to the module config to avoid a major refactor.
Hi @dxtech-git, is this a white label? This appears to be very similar to dxkulture and both adapters start with dx 🙂.
@dxtech-git, @justadreamer suggested it might be easier if we discuss this offline to ensure copying is the right approach and offered to coordinate.
Please add dxkulture back in as part of this PR. Create a separate PR that just removes dxkulture so that we can tag it as 4.0 and merge it when...
@dxtech-git I'm not sure what happened but somehow the dxkulture files are showing as modified. Can you please resolve?
@dxtech-git thanks for the recent changes. There is still one outstanding comment that needs to be addressed: https://github.com/prebid/prebid-server/pull/4506#discussion_r2446025081
@Valentino3 please run `go fmt` so that the validate checks pass.
@Valentino3 please run `go fmt` again.
LGTM. Holding off on approving to ensure this doesn't get merged prematurely.
@sajzcom this PR has to wait for the next major release because it is a breaking change due to making `placement_id` a required parameter. We're planning to release 4.0 the...