Brian Sardo

Results 235 comments of Brian Sardo

@sangarbe please see above about incorrect macro.

@sangarbe please see issue above.

@Ivan-Z-Oprx please see most recent comment above.

Hi @dxtech-git, I am confused as to what you're trying to do. I thought the first PR was going to add dxtech and then this PR would remove dxkulture but...

@dxtech-git you're adding dxtech in #4506. The only thing this PR should be doing is deleting the `dxkulture` directory and all of its contents.

Hi @dev-adverxo, adapters including hard aliases may only be removed in major releases because they are breaking changes. We can remove it as part of the next major release, 4.0,...

@ShriprasadM can you please review?

@support-gotham-ads we are coming up on the 4.0 release shortly. Can you please merge with master to resolve the conflicts? Also can you please open a docs PR to remove...

Discussed in backlog, seems straightforward but waiting to meet with @justadreamer to confirm intention before moving to ready for dev.

@Net-burst just checking if you have any thoughts here. Discussed at the PMC and we are ready to move it to ready-for-dev if you're good with this addition.