Brian Sardo

Results 235 comments of Brian Sardo

> This error again... But I found the reason: since `relevantSegments` is a hash-based map, there is no guarantee of the order of the keys, and because of this we...

@CTMBNara we'll give this another look this week.

@CTMBNara sorry for the delay. We'll get to this again shortly.

> With this PR, can we finally enable? Or should we keep line 62 below? > > ``` > 60 // Events indicates the various types of events to be...

Hi @Pubmatic-Dhruv-Sonone, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example: ``` import ( "github.com/prebid/prebid-server/v3/adapters"...

@Pubmatic-Dhruv-Sonone see my latest comments.

@Pubmatic-Dhruv-Sonone as discussed offline, I will look into whether `events_enabled` is still in use to determine if this is a breaking change. I still need your input on this [comment](https://github.com/prebid/prebid-server/pull/3803#discussion_r1926315999)...

Discussed in committee. @bretg do you recall why this module was designed this way? The general opinion here is that this a bug but there is some concern as to...

I'll put up a PR to pass `auctiontimestamp` through. Update is in `exchange/utils.go#buildRequestExtForBidder`

Hi @AntoxaAntoxic, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from `v2` to `v3`. For example: ``` import ( "github.com/prebid/prebid-server/v3/adapters"...