prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard

New Adapter: DXTech

Open dxtech-git opened this issue 4 months ago β€’ 24 comments

dxtech-git avatar Aug 30 '25 21:08 dxtech-git

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4c66e15299d1628b4162a5d0032ee0fd9396da65

dxtech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:35:	MakeRequests	90.5%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:76:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:114:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:123:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:143:	getHeaders	100.0%
total:									(statements)	97.1%

github-actions[bot] avatar Aug 30 '25 21:08 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 0f8df22855c703bdd3e0bf1cb97dd4c4fa452171

dxtech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:35:	MakeRequests	90.5%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:76:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:114:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:123:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:143:	getHeaders	100.0%
total:									(statements)	97.1%

github-actions[bot] avatar Sep 08 '25 19:09 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, a5b157c07220daa0b826da1df2b44106a4070be9

dxtech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:35:	MakeRequests	90.5%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:76:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:114:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:123:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:143:	getHeaders	100.0%
total:									(statements)	97.1%

github-actions[bot] avatar Sep 08 '25 20:09 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 70f4de35954c6e525613cdb93c17b23bbb43b3f8

dxtech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:35:	MakeRequests	90.5%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:76:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:114:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:123:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:143:	getHeaders	100.0%
total:									(statements)	97.1%

github-actions[bot] avatar Sep 08 '25 20:09 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, dee4b304845f8dfb5246076a943031b3736af007

dxtech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:27:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:34:	MakeRequests	90.5%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:75:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:113:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:122:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:142:	getHeaders	100.0%
total:									(statements)	97.1%

github-actions[bot] avatar Sep 08 '25 20:09 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, e841a41dc0f4c40ff2e9733a17a3ffc303d4f714

dxtech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:27:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:34:	MakeRequests	90.5%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:75:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:113:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:122:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:142:	getHeaders	100.0%
total:									(statements)	97.1%

github-actions[bot] avatar Sep 09 '25 18:09 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 7b78dc98427a675c8f722cc4a1b96aa34c68d326

dxtech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:27:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:34:	MakeRequests	90.5%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:75:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:113:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:122:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:142:	getHeaders	100.0%
total:									(statements)	97.1%

github-actions[bot] avatar Sep 09 '25 18:09 github-actions[bot]

Looks good. Sent out an email to [email protected] just to confirm is an active email address. Please respond to our email so I can approve

guscarreon avatar Sep 10 '25 03:09 guscarreon

Hi @dxtech-git, is this a white label? This appears to be very similar to dxkulture and both adapters start with dx πŸ™‚.

bsardo avatar Sep 23 '25 15:09 bsardo

Hi Yes it’s a white label. Will be happy if we approve this as soon as possible. Thanks! On Tue, 23 Sep 2025 at 18:00 Brian Sardo @.***> wrote:

bsardo left a comment (prebid/prebid-server#4506) https://github.com/prebid/prebid-server/pull/4506#issuecomment-3324402372

Hi @dxtech-git https://github.com/dxtech-git, is this a white label? This appears to be very similar to dxkulture and both adapters start with dx πŸ™‚.

β€” Reply to this email directly, view it on GitHub https://github.com/prebid/prebid-server/pull/4506#issuecomment-3324402372, or unsubscribe https://github.com/notifications/unsubscribe-auth/BWGXZGU2MLPLH6FY6AKUMQL3UFOCHAVCNFSM6AAAAACFHGAYGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMRUGQYDEMZXGI . You are receiving this because you were mentioned.Message ID: @.***>

dxtech-git avatar Sep 23 '25 15:09 dxtech-git

@dxtech-git, @justadreamer suggested it might be easier if we discuss this offline to ensure copying is the right approach and offered to coordinate.

bsardo avatar Oct 08 '25 19:10 bsardo

  • dxkulture is deprecated and should be removed in the next major version of Prebid Server 4.0. so this is the codebase that will live going forward

  • @dxtech-git please create a separate PR that deletes the files of dxkulture - it will be tagged for 4.0 to be merged.

justadreamer avatar Oct 09 '25 13:10 justadreamer

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 2e977059ef2e409cb04b538c888c36f005aa4f8d

dxtech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:27:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:34:	MakeRequests	90.5%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:75:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:113:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:122:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:142:	getHeaders	100.0%
total:									(statements)	97.1%

github-actions[bot] avatar Oct 09 '25 13:10 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, df574d618ac949beace8fcc2f4b4973871acaef0

dxtech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:27:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:34:	MakeRequests	90.5%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:75:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:113:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:122:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:142:	getHeaders	100.0%
total:									(statements)	97.1%

github-actions[bot] avatar Oct 14 '25 20:10 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 59f119699a5018f09932d31415791566d7ab605e

dxtech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:27:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:34:	MakeRequests	90.5%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:75:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:113:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:122:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:142:	getHeaders	100.0%
total:									(statements)	97.1%

github-actions[bot] avatar Oct 14 '25 20:10 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 0006732f9320f475c9e5597aa19043a3b5a07c13

dxtech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:27:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:34:	MakeRequests	90.5%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:75:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:113:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:122:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:142:	getHeaders	100.0%
total:									(statements)	97.1%

github-actions[bot] avatar Oct 15 '25 18:10 github-actions[bot]

Please add dxkulture back in as part of this PR. Create a separate PR that just removes dxkulture so that we can tag it as 4.0 and merge it when we cut 4.0 since it is technically a breaking change.

bsardo avatar Oct 20 '25 20:10 bsardo

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 9d1181e636239e28b050ec07abedaee30d8fef36

dxkulture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/dxkulture/dxkulture.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/dxkulture/dxkulture.go:35:	MakeRequests	90.5%
github.com/prebid/prebid-server/v3/adapters/dxkulture/dxkulture.go:76:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/dxkulture/dxkulture.go:114:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/dxkulture/dxkulture.go:123:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/dxkulture/dxkulture.go:143:	getHeaders	100.0%
total:									(statements)	97.1%

dxtech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:27:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:34:	MakeRequests	90.5%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:75:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:113:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:122:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:142:	getHeaders	100.0%
total:									(statements)	97.1%

github-actions[bot] avatar Oct 22 '25 19:10 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 0d24468a0f5da21ac67e0bc1aae05c072e0e1972

dxkulture

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/dxkulture/dxkulture.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/dxkulture/dxkulture.go:35:	MakeRequests	90.5%
github.com/prebid/prebid-server/v3/adapters/dxkulture/dxkulture.go:76:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/dxkulture/dxkulture.go:114:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/dxkulture/dxkulture.go:123:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/dxkulture/dxkulture.go:143:	getHeaders	100.0%
total:									(statements)	97.1%

dxtech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:27:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:34:	MakeRequests	90.5%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:75:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:113:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:122:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:142:	getHeaders	100.0%
total:									(statements)	97.1%

github-actions[bot] avatar Oct 22 '25 19:10 github-actions[bot]

Please add dxkulture back in as part of this PR. Create a separate PR that just removes dxkulture so that we can tag it as 4.0 and merge it when we cut 4.0 since it is technically a breaking change.

https://github.com/prebid/prebid-server/pull/4579

dxtech-git avatar Oct 22 '25 19:10 dxtech-git

@dxtech-git I'm not sure what happened but somehow the dxkulture files are showing as modified. Can you please resolve?

bsardo avatar Oct 22 '25 20:10 bsardo

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, df574d618ac949beace8fcc2f4b4973871acaef0

dxtech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:27:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:34:	MakeRequests	90.5%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:75:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:113:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:122:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:142:	getHeaders	100.0%
total:									(statements)	97.1%

github-actions[bot] avatar Oct 23 '25 17:10 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, a818d080b1bea0248dbcfb40bcecfd55eaae9f69

dxtech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:27:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:34:	MakeRequests	90.5%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:75:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:113:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:122:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:142:	getHeaders	100.0%
total:									(statements)	97.1%

github-actions[bot] avatar Oct 23 '25 17:10 github-actions[bot]

@dxtech-git I'm not sure what happened but somehow the dxkulture files are showing as modified. Can you please resolve?

Please check now.

dxtech-git avatar Oct 23 '25 17:10 dxtech-git

@dxtech-git thanks for the recent changes. There is still one outstanding comment that needs to be addressed: https://github.com/prebid/prebid-server/pull/4506#discussion_r2446025081

bsardo avatar Nov 20 '25 16:11 bsardo

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6e2c571037d1bfcbb7a409967fb25f843cacf558

dxtech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:27:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:34:	MakeRequests	90.5%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:75:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:113:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:122:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:142:	getHeaders	100.0%
total:									(statements)	97.1%

github-actions[bot] avatar Dec 16 '25 09:12 github-actions[bot]

@dxtech-git thanks for the recent changes. There is still one outstanding comment that needs to be addressed: #4506 (comment)

@bsardo Done.

dxtech-git avatar Dec 16 '25 19:12 dxtech-git