prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard
verified publisher icon prebid

ResetDigital: OpenRTB

Open Valentino3 opened this issue 4 months ago • 12 comments

New branch for Reset Digital work. All future commits will be here. Replaces: https://github.com/prebid/prebid-server/pull/4349

Clean branch; continuing Reset Digital updates here going forward. Supersedes: https://github.com/prebid/prebid-server/pull/4349

Active branch for Reset Digital changes from now on. Replaces: https://github.com/prebid/prebid-server/pull/4349

New working branch—use this for all future Reset Digital commits. Supersedes: https://github.com/prebid/prebid-server/pull/4349

Valentino3 avatar Aug 06 '25 16:08 Valentino3

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, c156aa97602673091b02aa69f45c3cffc7a4d218

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:32:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:38:	MakeRequests		89.3%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:127:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:158:	parseBidResponse	88.9%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:197:	getBidType		78.6%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:227:	getMediaType		100.0%
total:										(statements)		89.7%

github-actions[bot] avatar Aug 06 '25 16:08 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 9da075d50a102c62ea77afcd018b8376289c41b2

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:32:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:38:	MakeRequests		87.5%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:121:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:152:	parseBidResponse	90.5%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:196:	getBidType		88.9%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:212:	getMediaType		100.0%
total:										(statements)		91.7%

github-actions[bot] avatar Aug 18 '25 17:08 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6727af3e2be994baed66a138604d4be22c2ca9f5

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:32:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:38:	MakeRequests		87.5%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:121:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:152:	parseBidResponse	90.5%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:195:	getBidType		88.9%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:214:	getMediaType		100.0%
total:										(statements)		91.7%

github-actions[bot] avatar Aug 19 '25 18:08 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 051dcf786732e1f95b9026de44a11a7aa97ec8b0

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:34:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:40:	MakeRequests			90.9%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:119:	MakeBids			100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:150:	parseBidResponse		90.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:192:	getBidType			88.9%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:211:	validateAndFilterCurrencies	100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:229:	getMediaType			100.0%
total:										(statements)			93.8%

github-actions[bot] avatar Aug 27 '25 16:08 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 8fc30e6e432d38d3d26ebed497e4516b6e5bb6d8

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:34:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:40:	MakeRequests			90.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:113:	MakeBids			100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:144:	parseBidResponse		90.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:186:	getBidType			100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:205:	validateAndFilterCurrencies	100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:223:	getMediaType			100.0%
total:										(statements)			94.9%

github-actions[bot] avatar Sep 11 '25 14:09 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, ff2bcb04de8f2c24151e45062f36afad5164ca2d

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:34:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:40:	MakeRequests			90.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:113:	MakeBids			100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:144:	parseBidResponse		90.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:186:	getBidType			100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:205:	validateAndFilterCurrencies	100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:223:	getMediaType			100.0%
total:										(statements)			94.9%

github-actions[bot] avatar Sep 15 '25 15:09 github-actions[bot]

@Valentino3 please run go fmt so that the validate checks pass.

bsardo avatar Sep 29 '25 13:09 bsardo

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 05b64334803ffaacacff587cd33ff92e59c81dd6

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:34:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:40:	MakeRequests			95.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:113:	MakeBids			100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:144:	parseBidResponse		100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:186:	getBidType			100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:205:	validateAndFilterCurrencies	100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:223:	getMediaType			100.0%
total:										(statements)			98.7%

github-actions[bot] avatar Oct 13 '25 20:10 github-actions[bot]

@Valentino3 please run go fmt again.

bsardo avatar Oct 16 '25 18:10 bsardo

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b66943a400bd0d3cb54e1fa6dad266802283eaec

resetdigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:34:	Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:40:	MakeRequests			95.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:113:	MakeBids			100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:144:	parseBidResponse		100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:186:	getBidType			100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:205:	validateAndFilterCurrencies	100.0%
github.com/prebid/prebid-server/v3/adapters/resetdigital/resetdigital.go:223:	getMediaType			100.0%
total:										(statements)			98.7%

github-actions[bot] avatar Oct 16 '25 18:10 github-actions[bot]

LGTM. Holding off on approving to ensure this doesn't get merged prematurely.

bsardo avatar Oct 22 '25 18:10 bsardo

Hi team. Just checking, this PR was approved before the November release, but it doesn’t look like it was included. Could you confirm if it was missed or planned for the next release?

sajzcom avatar Nov 10 '25 14:11 sajzcom

@sajzcom this PR has to wait for the next major release because it is a breaking change due to making placement_id a required parameter. We're planning to release 4.0 the first week of January 2026.

bsardo avatar Dec 17 '25 18:12 bsardo