prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard

New Adapter: Matterfull

Open Matterfull opened this issue 7 months ago • 20 comments

Docs PR - https://github.com/prebid/prebid.github.io/pull/6042

Matterfull avatar May 19 '25 09:05 Matterfull

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 93e1c5f886eccbda1d3e6adf4a5b1ae266b38047

matterfull

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:23:	MakeRequests		83.3%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:53:	getImpressionsInfo	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:83:	validateImpression	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:91:	compatImpression	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:99:	compatBannerImpression	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:118:	getImpressionExt	85.7%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:134:	buildAdapterRequest	83.3%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:159:	createBidRequest	75.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:180:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:186:	MakeBids		84.2%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:220:	getMediaTypeForImpID	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:230:	Builder			100.0%
total:										(statements)		89.7%

github-actions[bot] avatar May 19 '25 09:05 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 8164201ae70f38a61d91ba3b971a0c00e3df4631

matterfull

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:23:	MakeRequests		83.3%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:53:	getImpressionsInfo	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:83:	validateImpression	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:91:	compatImpression	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:99:	compatBannerImpression	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:118:	getImpressionExt	85.7%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:134:	buildAdapterRequest	83.3%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:159:	createBidRequest	75.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:180:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:186:	MakeBids		84.2%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:220:	getMediaTypeForImpID	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:230:	Builder			100.0%
total:										(statements)		89.7%

github-actions[bot] avatar May 19 '25 10:05 github-actions[bot]

@ShriprasadM can you please review?

bsardo avatar Jun 13 '25 17:06 bsardo

@ShriprasadM Hi! Can you please tell me the status of our adapter and what we need to do next?

Matterfull avatar Jun 18 '25 11:06 Matterfull

@ShriprasadM Please let us know if you need anything from our side in order to complete the review.

Matterfull avatar Jun 25 '25 12:06 Matterfull

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 51aeccd23d5eb9436edab8bd2331f4dbe09d4261

matterfull

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:22:	MakeRequests		80.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:49:	getImpressionsInfo	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:74:	compatImpression	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:82:	compatBannerImpression	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:101:	getImpressionExt	85.7%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:117:	buildAdapterRequest	83.3%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:142:	createBidRequest	75.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:163:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:169:	MakeBids		84.2%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:203:	getMediaTypeForImpID	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:213:	Builder			100.0%
total:										(statements)		88.6%

github-actions[bot] avatar Jun 30 '25 11:06 github-actions[bot]

@ShriprasadM Please let us know if you need anything from our side in order to complete the review.

@Matterfull : Was busy with some other work. I will look into this today

ShriprasadM avatar Jul 01 '25 06:07 ShriprasadM

@ShriprasadM Do we have any updates?

Matterfull avatar Jul 09 '25 09:07 Matterfull

@scr-oath I fixed the errors according to the last code review. Tell me, I think I incorrectly brought to the current version of the repository and pushed.

Matterfull avatar Jul 23 '25 10:07 Matterfull

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 135abd63f065476582b267e6cd22e113cc9fc9d8

matterfull

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:23:	MakeRequests		80.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:50:	getImpressionsInfo	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:75:	compatImpression	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:83:	compatBannerImpression	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:102:	getImpressionExt	85.7%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:118:	buildAdapterRequest	83.3%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:143:	createBidRequest	75.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:164:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:170:	MakeBids		83.3%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:202:	getMediaTypeForImpID	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:212:	Builder			100.0%
total:										(statements)		88.5%

github-actions[bot] avatar Jul 28 '25 10:07 github-actions[bot]

@scr-oath Hi, we fixed our pull request, the latest changes were added correctly and we ask for a re-code review.

Matterfull avatar Jul 28 '25 11:07 Matterfull

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, d94c014f06e7816bfcf6ebfa9f5cfbff7b29be56

matterfull

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:23:	MakeRequests		80.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:49:	getImpressionsInfo	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:74:	compatImpression	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:82:	compatBannerImpression	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:101:	getImpressionExt	85.7%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:117:	buildAdapterRequest	83.3%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:142:	createBidRequest	75.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:163:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:169:	MakeBids		83.3%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:201:	getMediaTypeForImpID	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:211:	Builder			100.0%
total:										(statements)		88.5%

github-actions[bot] avatar Jul 31 '25 12:07 github-actions[bot]

@scr-oath We have checked and responded to all previous tasks to improve the adapter. The latest found defects have been fixed. Please review the code again.

Matterfull avatar Jul 31 '25 12:07 Matterfull

@scr-oath Please check our latest changes.

Matterfull avatar Aug 06 '25 09:08 Matterfull

@scr-oath Can you please tell us what to do next?

Matterfull avatar Aug 11 '25 09:08 Matterfull

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 3a9338339f88f4df555f79454dcf228b2cb8816c

matterfull

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:23:	MakeRequests		80.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:49:	getImpressionsInfo	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:74:	compatImpression	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:82:	compatBannerImpression	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:99:	getImpressionExt	85.7%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:115:	buildAdapterRequest	83.3%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:140:	createBidRequest	72.7%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:158:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:164:	MakeBids		83.3%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:196:	getMediaTypeForImpID	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:206:	Builder			100.0%
total:										(statements)		88.3%

github-actions[bot] avatar Sep 15 '25 10:09 github-actions[bot]

@hhhjort @scr-oath We have released the changes, can you please check them?

Matterfull avatar Sep 19 '25 11:09 Matterfull

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4b5350a20e11fd572bb78ca030a047bbfa287404

matterfull

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:23:	MakeRequests		80.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:49:	getImpressionsInfo	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:74:	compatImpression	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:82:	compatBannerImpression	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:99:	getImpressionExt	85.7%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:115:	buildAdapterRequest	83.3%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:140:	createBidRequest	76.9%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:163:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:169:	MakeBids		81.2%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:203:	getMediaTypeForImpID	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:213:	Builder			100.0%
total:										(statements)		88.3%

github-actions[bot] avatar Sep 26 '25 10:09 github-actions[bot]

@scr-oath We've taken all your suggestions for improving code quality and made the final changes. Could you please review the code? We hope this will be the last one before the merge.

Matterfull avatar Sep 26 '25 11:09 Matterfull

@scr-oath @hhhjort Hello, we're waiting for our pull request to be merged. Can you give us some feedback on where we are in this process and when we'll have it ready?

Matterfull avatar Oct 13 '25 12:10 Matterfull

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 7313f833abf80a6543766a26337dbf3ea06f1af9

matterfull

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:23:	MakeRequests		80.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:49:	getImpressionsInfo	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:74:	compatImpression	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:82:	compatBannerImpression	80.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:112:	getImpressionExt	77.8%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:136:	buildAdapterRequest	83.3%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:161:	createBidRequest	76.9%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:184:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:190:	MakeBids		81.2%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:224:	getMediaTypeForImpID	100.0%
github.com/prebid/prebid-server/v3/adapters/matterfull/matterfull.go:234:	Builder			100.0%
total:										(statements)		85.3%

github-actions[bot] avatar Nov 21 '25 15:11 github-actions[bot]

@scr-oath. We checked our mail and it is absolutely correct. [email protected].

Matterfull avatar Nov 21 '25 15:11 Matterfull