prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard

Rename dxkulture adapter

Open dxtech-git opened this issue 2 months ago • 2 comments

Remove dxkulture, the new adapter is dxtech, Please tag it for 4.0

dxtech-git avatar Oct 22 '25 19:10 dxtech-git

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, ce527ded93b3cf99502ec4f07b4e5285df03aa85

dxtech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:27:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:34:	MakeRequests	90.5%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:75:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:113:	getBidType	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:122:	parseExt	100.0%
github.com/prebid/prebid-server/v3/adapters/dxtech/dxtech.go:142:	getHeaders	100.0%
total:									(statements)	97.1%

github-actions[bot] avatar Oct 22 '25 19:10 github-actions[bot]

Hi @dxtech-git, I am confused as to what you're trying to do. I thought the first PR was going to add dxtech and then this PR would remove dxkulture but now this one is renaming it. My suggestion was to have two PRs. The first one adds dxtech and can be merged at any time since it is not breaking. The second one would just remove dxkulture and we would tag it as 4.0 since removing an adapter is technically a breaking change.

bsardo avatar Oct 22 '25 20:10 bsardo

@dxtech-git you're adding dxtech in #4506. The only thing this PR should be doing is deleting the dxkulture directory and all of its contents.

bsardo avatar Nov 20 '25 16:11 bsardo