Bruno Garcia
Bruno Garcia
Force-pushed addressing https://github.com/bitcoin/bitcoin/pull/30183#discussion_r1803064149
Going to close it here since there is [bip152 types should be encapsulated to enforce size invariants rust-bitcoin/rust-bitcoin#2984](https://github.com/rust-bitcoin/rust-bitcoin/issues/2984). Thanks.
hmmm https://github.com/bitcoin/bitcoin/pull/22050/files#r645432156
Sounds good to drop TorV2 support, it's basically useless.
Closing this because rust-bitcoin just dropped support for TorV2 (https://github.com/rust-bitcoin/rust-bitcoin/commit/53d32c9e4f0ef0f3b2c7d4dcba42e3ac5344f78a). Thank you, @apoelstra
Still draft or ready for review?
``` In file included from init.cpp:25: ./httpserver.h:134:43: error: no matching constructor for initialization of 'std::span' (aka 'span') WriteReply(nStatus, std::as_bytes(std::span{reply})); ```
> Are you compiling with the most recent commit of bitcoin core? I tested commit 60b816439e and I see no such issues. Yes, and tried on master.
cc: @apoelstra
Thank you, @apoelstra.