bitcoinfuzz icon indicating copy to clipboard operation
bitcoinfuzz copied to clipboard

Add RPC Target

Open hax0kartik opened this issue 1 year ago • 5 comments

This is a rough draft right now because there are certain areas which need to be improved before merging:

  • Initialization : Preferably, we should report to the user in case the btcd server has not been executed yet. +1 if we can launch the server ourselves.

  • Code Cleanup : Minor Code cleanup is needed

hax0kartik avatar Aug 12 '24 14:08 hax0kartik

Still draft or ready for review?

brunoerg avatar Aug 19 '24 12:08 brunoerg

In file included from init.cpp:25:
./httpserver.h:134:43: error: no matching constructor for initialization of 'std::span<typename string_view::value_type>' (aka 'span<char>')
        WriteReply(nStatus, std::as_bytes(std::span{reply}));

brunoerg avatar Aug 19 '24 12:08 brunoerg

Still draft or ready for review?

I believe I am ready for review

hax0kartik avatar Aug 21 '24 03:08 hax0kartik

In file included from init.cpp:25:
./httpserver.h:134:43: error: no matching constructor for initialization of 'std::span<typename string_view::value_type>' (aka 'span<char>')
        WriteReply(nStatus, std::as_bytes(std::span{reply}));

Are you compiling with the most recent commit of bitcoin core? I tested commit 60b816439e and I see no such issues.

hax0kartik avatar Aug 21 '24 03:08 hax0kartik

Are you compiling with the most recent commit of bitcoin core? I tested commit 60b816439e and I see no such issues.

Yes, and tried on master.

brunoerg avatar Aug 21 '24 09:08 brunoerg