Bruno Garcia
Bruno Garcia
> The "should work without having access to the RPC interface" is the part that I'd like to understand better. For example, the electrs docs specifically mention the bitcoind jsonrpc...
A mutation testing report for this PR is available at: https://brunoerg.xyz/mutation-core-front
Concept ACK
> More about FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION can be found at https://llvm.org/docs/LibFuzzer.html#fuzzer-friendly-build-mode and https://github.com/AFLplusplus/AFLplusplus/blob/stable/docs/fuzzing_in_depth.md#d-modifying-the-target. Perhaps it would be good to mention this in docs?
> I briefly fuzzed after making the change and didn't hit anything. Likely I just didn't fuzz enough, but posting just in case somebody has a fuzz output that I...
> The assert in the harness should fail with that input after reverting https://github.com/bitcoin/bitcoin/commit/7ad15d11005eac36421398530da127333d87ea80 Yes, confirmed! ```sh Assertion failed: (WITH_LOCK(cs_main, return chainman.m_blockman.m_block_index.size()) == original_index_size), function p2p_headers_presync_fuzz_target, file p2p_headers_presync.cpp, line 197....
Concept ACK
> Neat! Can you move/copy this to rust-miniscript. I think this is a gap in our definition of DescriptorPublicKey. Yes! Done. https://github.com/rust-bitcoin/rust-miniscript/issues/785
I think you have more than one `ScriptPubKeyManager`. When you call `keypoolrefill` it will top up every spkm. Did you check `listdescriptors`?