Bruno Garcia

Results 377 comments of Bruno Garcia

See https://github.com/bitcoin/bitcoin/pull/30345#issuecomment-2200659833 It seems there is something listening at port 60000 in parallel.

> Decode [coverage](https://marcofleon.github.io/coverage/bech32decode/) > Roundtrip [coverage](https://marcofleon.github.io/coverage/bech32roundtrip/) I don't see anything new in these reports compared to https://maflcko.github.io/b-c-cov/fuzz.coverage/src/index.html.

Why not just expanding the tests in `wallet_basic.py`?

> SigVersion::WITNESS_V0 and SigVersion::TAPSCRIPT scripts are currently not covered by this test, as fuzzers are blocked from e.g. creating a valid taproot script path spend commitment. The same applies to...

@sanket1729 I think you need to call `sanity_check` after parsing the descriptor.

> @apoelstra, rust-miniscript differs from Bitcoin Core by analyzing if script elements are satisfiable. In this case 0 (OP_FALSE) in second thresh branch is not sensible as it's inherently unsatisfiable,...

> No, i don't think an unsatisfiable fragment should be considered as bumping against the ops limit. Make sense.