Bruno Garcia

Results 377 comments of Bruno Garcia

From CI: ``` 291/305 - rpc_help.py failed, Duration: 1 s stdout: 2024-05-10T15:06:20.992000Z TestFramework (INFO): PRNG seed is: 4539310303736745094 2024-05-10T15:06:20.998000Z TestFramework (INFO): Initializing test directory /ci_container_base/ci/scratch/test_runner/test_runner_₿_🏃_20240510_150004/rpc_help_7 2024-05-10T15:06:21.349000Z TestFramework (ERROR): Assertion failed...

There are some places you are using `assert_not_equal` but not importing it and other ones you're importing it twice. Check CI. ``` Running Unit Tests for Test Framework Modules Traceback...

> I generated a coverage report for the current ScriptPubKeyMan harness and for the updated harness in this PR. @marcofleon It's good to mention how you run it. How many...

You can squash some commits.

From CI: ``` SUMMARY: UndefinedBehaviorSanitizer: invalid-null-argument test/fuzz/util/net.cpp:219:66 MS: 0 ; base unit: 0000000000000000000000000000000000000000 0x5c,0x57,0x5c,0x57,0x5c,0xfb,0xff,0x29,0xa5,0x6,0x6,0xff,0x29,0x35,0xda, \\W\\W\\\373\377)\245\006\006\377)5\332 artifact_prefix='./'; Test unit written to ./crash-c88fdfee4792d18945ffb11a7a520d9f0fb5e56b Base64: XFdcV1z7/ymlBgb/KTXa Traceback (most recent call last): File "/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/fuzz/test_runner.py",...

Pushed 66572c27454e1464173dc318d62fdfc11d4b7832..6e026606f368d8d1139b266c382076685e76d0b2 to address https://github.com/bitcoin/bitcoin/pull/32175#discussion_r2042642262

> I noticed that a couple lines above, the link to "selecting the best AFL compiler..." is invalid and has instead moved to https://github.com/AFLplusplus/AFLplusplus/blob/stable/docs/fuzzing_in_depth.md#a-selecting-the-best-afl-compiler-for-instrumenting-the-target. I can open a PR to...

Force-pushed addressing https://github.com/bitcoin/bitcoin/pull/30445#discussion_r1756250067