Brian Anderson

Results 400 comments of Brian Anderson

@HCastano I am happy to include this feature, though I am interested to know your use case if you can tell me what you will be doing with the version...

It would also be possible to expose this as a static value `BINARYEN_VERSION`, though it would require emitting some Rust code from the `wasm-opt-sys` build script (probably into `OUT_DIR/binaryen_version.rs` or...

I was not familiar with build metadata. Seems like a good idea. I have to decide how to clean up the mess I've already made for us since we're now...

This is a reasonable idea, but I'm going to sit on it for a bit. Needs a major version bump anyway. The major drawback of the dual bin/lib crate from...

Also of course the non-split crate forces a build of the `wasm-opt` lib to build the bin. It is also not a great deal of code. `wasm-opt-sys` dominates the build.

Sounds good to me. I'll probably reformat everything with the defaults. The only syntactic decision I care about is the redundant use of namespace blocks.

Add it to the existing cargo fmt ci job

Can't solve this, but we'll file an issue against tarpaulin.

That is awesome. I mentioned in your other bug report that we will publish a much more complete and tested build, ready for integration, within a few days. I'll give...

@sanmai-NL the issues you are raising seem to be different from this issue, which is about ensuring that individual rust-lang repos declare a license (and on that basis I think...