Brian Anderson

Results 400 comments of Brian Anderson

FWIW in the fuzzing I am doing on blend I am currently doing two new things that I think will help a lot: I am not allowing contracts to implicitly...

It looks like this fails the build on our minimum Rust version 1.48: https://github.com/brson/wasm-opt-rs/actions/runs/7015422941/job/19305682921?pr=162 Seems that syn 2.0 doesn't support such an old compiler.

master has in ignored test now. Unicode paths don't work on windows yet, but also binaryen just prints to console and exits when it fails to read a file: ```...

My suspicion is that binaryen doesn't work with unicode paths on windows because it doesn't have any explicit wide char support. I am investigating whether the wasm-opt CLI does somehow...

I have made progress on this in my binaryen unicode branch: https://github.com/brson/binaryen/tree/unicode It is able to build a wasm-opt that handles unicode paths on windows. Still have to convert all...

This is fixed in binaryen now. Doesn't seem to be in 116, so I'll try to retest in 117.

Reusing the official binaries is a clever idea. It sounds possible and I can't think of any reason it couldn't work in common cases. The main complication I can think...

Hi @xermicus. Thanks for this report. We've reproduced the problem. It was introduced in 0.114.1, in this pr https://github.com/brson/wasm-opt-rs/pull/151. I thought this would not be a breaking change, but hadn't...

@tareknaser I think we'll put out a new build of 0.114 this week, and a also 0.116.

We've done as discussed previously: - yanked 0.114.1 - published 0.114.2 with a "dwarf" feature that enables the LLVM code and dwarf passes - this is a non-default feature for...