Brian Anderson
Brian Anderson
@kentosugama I think that is a feature we can add. The reason the crate doesn't support it currently is because the underlying binaryen APIs don't, so it will take some...
I've filed an issue upstream to see how they feel about adding the APIs to binaryen. @kentosugama In your use case would you still be compiling the wasm-opt crate for...
I have reproduced this on my own CI on windows 2019: https://github.com/brson/wasm-opt-rs/actions/runs/3447794546/jobs/5754178052 Simply running `cargo clean` immediately after the build fails with access denied. I originally suspected this was an...
I could _not_ reproduce this locally on windows 10 running cargo clean by hand. Perhaps there is a timing factor here.
I've also verified this happens on CI windows 2019 with Rust stable: https://github.com/brson/wasm-opt-rs/actions/runs/3447938335/jobs/5754469499 So it's not related to an old cargo. Still can't reproduce locally.
cc @dtolnay I can't investigate much deeper yet, but maybe the issue will be obvious to you. After running the build on GitHub actions, on either Windows 2019 or Windows...
When I tested this I did try throwing some sleeps into the script, like `sleep 2 || cargo clean || sleep 2 || cargo clean`, etc. and it still failed....
@ChrisDenton thank you very much for the investigation. That is a fascinating result.
The lack of caching in the C++ build step is the big disadvantage of how we're building binaryen using only the `cc` crate and without `cmake`. Any time the wasm-opt-sys...
I've thought a bit about how to add a caching layer on top of the cc crate, and I have not come up with a plan that I think will...